SCM

[#1000795] Missing method QueryLogObject::appendDetail()

View Trackers | Bugs | Download .csv | Monitor

Date:
2006-12-02 12:48
Priority:
3
State:
Open
Submitted by:
Michal Taborsky (whizz)
Assigned to:
Guillaume Smet (gsmet)
Category:
Group:
Resolution:
None
 
Summary:
Missing method QueryLogObject::appendDetail()

Detailed description
I am using 0.7.1 installed from RPM on CentOS 4.4 (Redhat ES 4). I am getting this error. Indeed, the method does not exists.

PHP Fatal error: Call to undefined method QueryLogObject::appendDetail() in /usr/share/pgfouine/include/postgresql/lines/PostgreSQLDetailLine.class.php on line 28



The callign code is:
class PostgreSQLDetailLine extends PostgreSQLLogLine {
var $ignore = false;

function appendTo(& $logObject) {
$logObject->appendDetail($this->text);
}
}

Followup

Message
Date: 2006-12-11 22:55
Sender: Guillaume Smet

Michal,

I don't like this solution because it can hide future problems or changes of the PostgreSQL log format.

Note that if you make it does nothing, it affects the result as it should append the text to the text of the query. So in your case, you should add:
function appendDetail($detail) {
$this->append($detail);
}
to QueryLogObject.

I must admit that I prefer well known bugs to erratic behaviours so I'm still looking for a better and safer solution.

That said, I may consider to simply add this workaround if I (or others) don't find any better solution for 0.8.

Regards,

--
Guillaume
Date: 2006-12-11 21:47
Sender: Michal Taborsky

Well, I suggest at least ignoring this type of log line by
including the method, which does nothing. This is what I did
to make pgFouine work for me. It did not affect the results,
as far as I know.
Date: 2006-12-11 21:35
Sender: Guillaume Smet

Summary of private email conversation with Michal:
The problem is due to the fact that Michal inserts PostgreSQL log lines into his PostgreSQL database and so pgFouine considers the text of the log line inserted as a valid DETAIL line.
I don't have any solution to fix this atm apart from a workaround e.g. make the parser more strict about spaces (which could work in Michal's case considering his log file but not in general)...
It won't be fixed in 0.7 stable branch so it's delayed for 0.8. Ideas for fixing this problem are highly welcome.

Attached Files:

Changes:

Field Old Value Date By
assigned_tonone2006-12-11 21:35gsmet
Powered By FusionForge