SCM

[#1010210] Two bugs with parsing "HINT:" and "free space" lines

View Trackers | Bugs | Download .csv | Monitor

Date:
2007-12-05 21:47
Priority:
3
State:
Open
Submitted by:
Dmitry Koterov (dmitry_koterov)
Assigned to:
Guillaume Smet (gsmet)
Category:
Group:
Resolution:
None
 
Summary:
Two bugs with parsing "HINT:" and "free space" lines

Detailed description
Hello.

I have to pre-filter by Postgres logs with

grep -v "HINT:\|free space"

because else I've got PHP errors:


1. For pgfouine:

PHP Fatal error: Call to undefined method QueryLogObject::appendHint() in /usr/share/pgfouine/include/postgresql/lines/PostgreSQLHintLine.class.php on line 28


2. For pgfouine_vacuum:

PHP Fatal error: Call to undefined method FSMInformationLogObject::addIndexInformation() in /usr/share/pgfouine/include/postgresql/vacuum/lines/PostgreSQLIndexCleanupInformationLine.class.php on line 39


Seems somewhere in the code (I have spent about 20 minutes to learn it, but failed with it) logger passed to appendTo() is not proper.

Followup

Message
Date: 2011-02-03 20:56
Sender: Hubert Lubaczewski

Unfortunately I cannot provide logs, as they belong to client, but I think I was able to narrow the bug down pretty well.

In my logs, I have line which looks like:

LOG: duration: 373.701 ms execute pdo_pgsql_stmt: ....

this query uses placeholder, so next "line" contains parameters:

DETAIL: parameters: $1 = '.....

*but* - if the parameter contains new line characters, they are represented literally in logs.

So, if one of parameters is

... $10 = 'whatever\n HINT: dasjkhas dljkh anything'

it gets logged as 2 (or more) lines.

And in such case - HINT: causes the error.

Simple s/HINT:/HINT/ solved the problem, but I think it's a bug in parser.
Date: 2010-10-25 22:26
Sender: Roberto Marzialetti

i have the same problem (v. 1.2).
if you want, i can send my logfile

thanks.

Rob
Date: 2010-04-21 14:05
Sender: Guillaume Smet

Laurent,

Can you send me a log file (email is fine) so that I can reproduce the problem?

Thanks.
Date: 2010-04-21 10:05
Sender: Laurent Wandrebeck

Bug still there with 1.2 version. grepping -v "HINT:\|free space" turns around the problem.

Attached Files:

Changes:

Field Old Value Date By
summaryTwo bugs with parsing "HINT:" and "free space" lines2010-04-21 14:05gsmet
assigned_tonone2008-02-25 23:00gsmet
summaryTwo bugs with parsing "HINT:" and "free space" lines2008-02-25 23:00gsmet
Powered By FusionForge