SCM

[#1010489] Binary "AND" instead of logic "AND" makes pgreplicate subprocesses hang in HP-UX.

View Trackers | Bugs | Download .csv | Monitor

Date:
2008-10-08 11:39
Priority:
3
State:
Open
Submitted by:
Maximiliano Pin (maxpin)
Assigned to:
Nobody (None)
Category:
Group:
Resolution:
None
 
Summary:
Binary "AND" instead of logic "AND" makes pgreplicate subprocesses hang in HP-UX.

Detailed description
We noticed pgreplicate subprocesses stay in the system forever. A new subprocess is created and never destroyed, every time a postgres connection is closed. We are working with HP-UX. I've been debugging the code and found the problem.

In file pgrp/rlog.c, function send_message(), see this line:

else if (rtn & FD_ISSET(sock, &wmask))

That binary AND should be a logical AND (&&). This is maybe not problematic in other operating systems, because of the implementation of FD_ISSET, but it is problematic in HP-UX. I changed that and our problem disappeared.

Please fix it in the code for future versions. Thank you, and thanks for this piece of software.

Followup

No Followups Have Been Posted

Attached Files:

Changes:

No Changes Have Been Made to This Item

Powered By FusionForge