[#1010700] Capture parameter names with NpgsqlCommandBuilder.DeriveParameters

Date:
2009-09-09 17:56 Priority:
3

State:
Open

Submitted by:
Brian Schloz (bschloz) Assigned to:
Nobody (None)

Category:
Interface Improvements (example) Group:
Next Release (example)

Resolution:
None

Summary:
Capture parameter names with NpgsqlCommandBuilder.DeriveParameters

Detailed description
Currently, NpgsqlCommandBuilder.DeriveParameters method only retrieves the type and then adds generically the parameter names (e.g. parameter1, parameter2, ...). It would be useful to also capture the parameter names. I have a specific need for this but it would also be consistent with other data providers. I've reviewed the source code and believe this would be an easy fix. I would be happy to provide a patch if this seems reasonable. Brian

Followup

Message
Date: 2009-09-14 13:34 Sender: Brian Schloz Affirmative. Latest build works fine for me. Thank you much.
Date: 2009-09-12 23:09 Sender: Francisco Figueiredo jr. Patch applied to CVS. Please, give it a try and let us know if it worked for you. Also added a nunt testcase Thanks in advance.
Date: 2009-09-10 18:58 Sender: Brian Schloz Sorry, here is another version - forgot null check on names.
Date: 2009-09-10 18:55 Sender: Brian Schloz Here is the updated NpgsqlCommandBuilder (from the 2.0.6 branch).
Date: 2009-09-10 12:50 Sender: Josh Cooley Please share the patch. We'd be happy to review it.

Attachments:

NpgsqlCommandBuilder.cs

Field	Old Value	Date	By
File Added	424: NpgsqlCommandBuilder.cs	2009-09-10 18:58	bschloz
File Added	423: NpgsqlCommandBuilder.cs	2009-09-10 18:55	bschloz