[#1011021] Support DbMetaDataCollectionNames.ReservedWords

Date:
2011-04-25 05:28 Priority:
3

State:
Open

Submitted by:
Patrick Earl (patearl) Assigned to:
Nobody (None)

Category: Group:

Resolution:
None

Summary:
Support DbMetaDataCollectionNames.ReservedWords

Detailed description
NHibernate uses the following code to get a list of reserved words from ADO.NET providers. Unfortunately Npgsql does not support this. public virtual ISet<string> GetReservedWords() { var result = new HashedSet<string>(); DataTable dtReservedWords = connection.GetSchema(DbMetaDataCollectionNames.ReservedWords); foreach (DataRow row in dtReservedWords.Rows) { result.Add(row["ReservedWord"].ToString()); } return result; } The lack of this feature is currently causing many tests to fail. Thankfully, using the following chart the feature should be easy to implement. http://www.postgresql.org/docs/9.0/interactive/sql-keywords-appendix.html I'd be happy to test it and report back if it could be implemented.

Followup

Message
Date: 2011-04-28 06:10 Sender: Patrick Earl Works. :) Next up is foreign key schema GetSchema support.
Date: 2011-04-27 13:11 Sender: Francisco Figueiredo jr. Committed in cvs. Thank you very much for your patch! Please, give it a try and let me know if it works for you ok.
Date: 2011-04-27 05:05 Sender: Patrick Earl I've attached a patch that implements this using the latest reserved words list from the PostgreSQL documentation. With the patch applied, 6 more tests from NHibernate pass successfully. There are no other failing keyword related tests.

Attachments:

ReservedWords.patch

Field	Old Value	Date	By
File Added	599: ReservedWords.patch	2011-04-27 05:04	patearl