SCM

[#1011166] Missing null check in NpgsqlDataReader

View Trackers | Patches | Download .csv | Monitor

Date:
2012-02-23 00:28
Priority:
3
State:
Open
Submitted by:
Matthew Gabeler-Lee (cheetah)
Assigned to:
Nobody (None)
Category:
Group:
Resolution:
None
 
Summary:
Missing null check in NpgsqlDataReader

Detailed description
I ran into a NullReferenceException in Npgsql and tracked it down to a missing null check in NpgsqlDataReader. Tiny patch fixing this is attached.

Followup

Message
Date: 2012-02-23 00:38
Sender: Francisco Figueiredo jr.


I remember I played a little bit with this code.

I also noticed that ado.net needed at least an empty DataTable to be returned too. But I don't recall at this moment if there was another problem by returning an empty datatable...

I'll check that too.

Again, thanks for your patch and heads up!
Date: 2012-02-23 00:36
Sender: Francisco Figueiredo jr.

Yes, I agree with you it is confusing...
Thanks for your patch! I'll check and apply it.
Date: 2012-02-23 00:34
Sender: Matthew Gabeler-Lee

Oops, didn't even see that checkbox ... confusing thing to
have there, but the patch should actually be uploaded this time.
Date: 2012-02-23 00:33
Sender: Francisco Figueiredo jr.

Hi, Matthew!

Thanks for your patch submission. But I think you forgot to add the patch file itself.

I think maybe this was caused by not checking the checkbox above the Choose File button? :)

Attached Files:

Attachments:
bugfixes.patch

Changes:

Field Old Value Date By
File Added724: bugfixes.patch2012-02-23 00:34cheetah
Powered By FusionForge