SCM

[#1011336] Cannot make the tests to pass

View Trackers | Bugs | Download .csv | Monitor

Date:
2013-05-27 17:36
Priority:
3
State:
Closed
Submitted by:
Francisco Figueiredo jr. (fxjr)
Assigned to:
Nobody (None)
Npgsql Version:
None
Category:
None
Group:
None
Resolution:
None
Summary:
Cannot make the tests to pass

Detailed description
From: https://github.com/franciscojunior/Npgsql2/issues/12
github user: callixte


HI there,

I am trying to recompile this driver, but the tests are failing. I tested against a 8.4, 9.0 and 9.2 server, I always have some that are failing.
Maybe I am missing something.
I use VS2010 solution, clean the db and regenerate it everytime, but I still have some tests failing.
Thanks.

Followup

Message
Date: 2013-12-07 22:01
Sender: Shay Rojansky

No longer relevant since the test reorganizations for release 2.1.0
Date: 2013-05-27 17:37
Sender: Francisco Figueiredo jr.

I think those differences exist because I'm using Mono and you are using ms.net. I remember that Npgsql has problems with the data adapter and dataset tests when running under Mono. I still need to investigate that more.

About the monetary problem, I have en_US.UTF-8 and my lc_monetary.
This is my configuration:

lc_messages = 'en_US.UTF-8' # locale for system error message
# strings
lc_monetary = 'en_US.UTF-8' # locale for monetary formatting
lc_numeric = 'en_US.UTF-8' # locale for number formatting
lc_time = 'en_US.UTF-8' # locale for time formatting

I also noticed that when running under windows, postgresql returns negative money value as ($10.50). I still have to check how to force postgresql to always return negative values as -$value or some other consistent way regardless of the locale.

About the bug 1011001 failure, can you print the value of cs1 and cs2 so we can check what is the difference between them?

Thanks for your feedback and let's keep cleaning up those tests so they work ok on both Mono and ms.net
Date: 2013-05-27 17:37
Sender: Francisco Figueiredo jr.


From user: callixte

SO I have fixed the add_data.sql scrpt to get data into TableF and that deals with the NullRefException I was having. We still have discrepencies in the tests that pass:
1) NpgsqlTests.CommandTests.FunctionCallStringEscape : passes for me
2) NpgsqlTests.CommandTests.DataTypeTests : same
NpgsqlTests.CommandTests.NegativeMoneySupport : fails for me
3) NpgsqlTests.CommandTestsV2.CommandTests.ByteaInsertWithPrepareSupport : passes for me
4) NpgsqlTests.CommandTestsV2.CommandTests.Bug1010788UpdateRowSource : passes for me
5) NpgsqlTests.CommandTestsV2.CommandTests.DataTypeTests : same
NpgsqlTests.CommandTests.NegativeMoneySupport : fails for me
6) NpgsqlTests.ConnectionTests.NpgsqlErrorRepro1 : same
NpgsqlTests.ConnectionTests.Bug1011001 : fails for me
NpgsqlTests.ConnectionTests.UseAllConnectionsInPool : fails for me NpgsqlTests.ConnectionTestsV2.NpgsqlErrorRepro1 : fails for me
NpgsqlTests.ConnectionTestsV2.Bug1011001 : fails for me
NpgsqlTests.ConnectionTestsV2.UseAllConnectionsInPool : fails for me
7) NpgsqlTests.DataAdapterTests.InsertWithDataSet : passes for me
8) NpgsqlTests.DataAdapterTests.DataAdapterUpdateReturnValue2 : same
9) NpgsqlTests.DataAdapterTests.UpdateLettingNullFieldValue : passes
10) NpgsqlTests.DataAdapterTests.UpdateWithDataSet : same
11) NpgsqlTests.DataAdapterTests.InsertWithCommandBuilderCaseSensitive : same
12) NpgsqlTests.DataAdapterTestsV2.DataAdapterTests.InsertWithDataSet : passes
13) NpgsqlTests.DataAdapterTestsV2.DataAdapterTests.DataAdapterUpdateReturnValue2 : same
15) NpgsqlTests.DataAdapterTestsV2.DataAdapterTests.UpdateLettingNullFieldValue : passes
16) NpgsqlTests.DataReaderTests.GetBytesSequential : same
NpgsqlTests.DataReaderTests.GetBytes : fails
17) NpgsqlTests.DataReaderTestsV2.DataReaderTests.GetBytesSequential : same
NpgsqlTests.DataReaderTestsV2.DataReaderTests.GetBytes : fails
18) NpgsqlTests.NpgsqlParameterTest.InferType_Enum : same
19) NpgsqlTests.NpgsqlParameterTest.InferType_Invalid : same
20) NpgsqlTests.NpgsqlParameterTest.InferType_TimeSpan : same
21) NpgsqlTests.NpgsqlParameterTest.ParameterType : same
22) NpgsqlTests.NpgsqlParameterTest.ParameterName : same
23) NpgsqlTests.NpgsqlParameterTest.SourceColumn : same
24) NpgsqlTests.NpgsqlParameterTest.NpgsqlDbTypeTest_Value_Invalid : same
25) NpgsqlTests.NpgsqlParameterTest.NpgsqlTypes_NpgsqlTimeStamp : same
26) NpgsqlTests.NpgsqlParameterTest.Value : same
27) NpgsqlTests.SystemTransactionsTest.DistributedTransactionRollback : passes
28) NpgsqlTests.SystemTransactionsTest.FunctionTestTimestamptzParameterSupport : same
29) NpgsqlTests.SystemTransactionsTest.TwoDistributedInSequence : same
30) NpgsqlTests.SystemTransactionsTest.ReuseConnection : same
31) NpgsqlTests.SystemTransactionsTestV2.SystemTransactionsTest.DistributedTransactionRollback : same
32) NpgsqlTests.SystemTransactionsTestV2.SystemTransactionsTest.FunctionTestTimestamptzParameterSupport : passes
33) NpgsqlTests.SystemTransactionsTestV2.SystemTransactionsTest.TwoDistributedInSequence : same
34) NpgsqlTests.SystemTransactionsTestV2.SystemTransactionsTest.ReuseConnection : same

I investigated a bit the NegativeMonetarySupport: when I set lc_monetary to 'English, United States', it fails because I get back '($10.50)' from the server which is interpreted as 10.5. When I set it to 'French, France', I get back '-€10,50' which is correctly interprted, but I have to send '-10,5'.
What is your lc_monetary?

Overall, which do you think the most strange?

Attached Files:

Changes:

Field Old Value Date By
status_idOpen2013-12-07 22:01roji
close_dateNone2013-12-07 22:01roji
details From: https://github.com/franciscojunior/Npgsql2/issues/12 github user: callixte HI there, I am trying to recompile this driver, but the tests are failing. I tested against a 8.4, 9.0 and 9.2 server, I always have some that are failing. Maybe I am missing something. I use VS2010 solution, clean the db and regenerate it everytime, but I still have some tests failing. Thanks. 2013-05-27 17:37fxjr
Powered By FusionForge